Fix nonascii_srcdir to work when non-ascii directories aren't supported #8512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the nonascii_srcdir in tests/test_build.py contained some logic to attempt to handle the case where non-ascii directories aren't supported, but it did not actually work because it fails to copy the test sources to the temporary directory. With this commit, the following test invocation, which previously failed, now pases: LANG=en_US.iso8859-1 python -m pytest test_build.py
tk0miya
reviewed
Dec 12, 2020
|
Thank you for your contribution. Good work! |
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
Dec 19, 2020
tk0miya
added a commit
that referenced
this pull request
Dec 20, 2020
test: Add comment for UnicodeEncodeError handler (refs: #8512)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the nonascii_srcdir in tests/test_build.py contained some
logic to attempt to handle the case where non-ascii directories aren't
supported, but it did not actually work because it fails to copy the
test sources to the temporary directory.
With this commit, the following test invocation, which previously
failed, now pases:
LANG=en_US.iso8859-1 python -m pytest test_build.py