CSS: Respect Pygments background color #7718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... except "classic" and "scrolls" themes.
This was referenced May 24, 2020
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most built-in themes set the background color of code blocks in some way, overriding the background color provided by Pygments. This means that Pygments styles with bright text colors will not be readable on the (typically bright) hard-coded background.
This PR removes the background color from all built-in themes except:
classic, where there are custom theme options for code text and background colors [seeclassic theme: remove codetextcolor/codebgcolor theme options #7720classic theme: default codetextcolor/codebgcolor doesn't override Pygments #7721]scrolls, which has a custom image as background