Don't return False always on __exit__() #6749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the python/mypy#7214, mypy-0.740 prefers a return value of __exit__() method which does not swallow exceptions is None instead of bool. mypy#7214: python/mypy#7214
Codecov Report
@@ Coverage Diff @@
## master #6749 +/- ##
==========================================
- Coverage 84.42% 84.41% -0.01%
==========================================
Files 266 267 +1
Lines 40474 40496 +22
Branches 5934 5937 +3
==========================================
+ Hits 34170 34186 +16
- Misses 4997 5000 +3
- Partials 1307 1310 +3
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
According to the python/mypy#7214, mypy-0.740 prefers a return value of
__exit__()method which does not swallow exceptions is Noneinstead of bool.