Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5959: classifier delimiter is not shown #5976

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Jan 21, 2019

Feature or Bugfix

  • Bugfix

Purpose

@tk0miya tk0miya added this to the 2.0.0 milestone Jan 21, 2019
font-style: normal;
margin: 0.5em;
content: ":";
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In HTML4CSS1 writer, <span class="classifier-delimiter">:</span> is used for the delimiter. On the other hand, In HTML5-polyglot writer, it is represented by CSS hack.
Since 2.0, we adopt HTM5-polyglot style.

Copy link
Contributor

@jschueller jschueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does fix our problem! Thanks!

@tk0miya tk0miya merged commit 294867c into sphinx-doc:master Jan 22, 2019
@tk0miya
Copy link
Member Author

tk0miya commented Jan 22, 2019

Thank you for confirming! just merged.

@tk0miya tk0miya deleted the 5959_classifier_delimiter branch January 22, 2019 16:37
@larsoner
Copy link
Contributor

Indeed, thanks for the quick fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants