Change the language type given to CatalogRepository
in tests
#12853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests gave
None
as the language.The
CatalogRepository
signature says thatlanguage
should be astr
:I also looked at whether the
language
type should be changed tostr | None
. I believe that it should not - outside of tests, the only callers (within Sphinx) ofCatalogRepository.__init__
pass inself.config.language
, whereconfig
is asphinx.config.Config
.Looking at that, I see:
This shows that the valid types at the config level do not include
types.NoneType
.