typecheck docs/conf.py

[danieleades]

No description provided.

[picnixz]

You should also update the signature of between below since they are hooks for the same event (but you can also do it in a follow-up PR since it's not directly tight to docs/conf.py itself).

[picnixz]

Good for me! you can do the follow-up PR on between if you want by the way.

[AA-Turner]

@picnixz I think the merge may have been slightly premature here -- the force push removed several changes, such as ensuring imports were in type checking block.

More minor, but also can we ensure that commit messages start with an imperative (eg Check doc/conf.py with mypy or etc).

A

[picnixz]

the force push removed several changes, such as ensuring imports were in type checking block.

Ah, actually, you marked the conversation as being resolved, so I assumed you wanted to keep it out (is it what you were thinking about)? We can revert the commit if needed though and amend the PR.

More minor, but also can we ensure that commit messages start with an imperative

Ah yes, this is something I wondered. I used for a long time [lint] message but I remembered a comment where you wanted to avoid the [...] and instead use topic: .... So, in the future, you would prefer always an imperative style in the commit title or do you want an imperative style in the commit description