Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValueError popping out in sphinx.ext.napoleon. #10709

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 25, 2022

There's some parts of the code still expecting a StopIteration instead.

Feature or Bugfix

  • Bugfix

Purpose

Closes #10701; see discussion starting at #9856 (comment).

There's some parts of the code still expecting a StopIteration instead.
@AA-Turner
Copy link
Member

I'm merging this to get the 5.1.1 release out, but it would be great to add more tests around Napolean, especially given how widely used it is.

A

@AA-Turner AA-Turner merged commit f8b8434 into sphinx-doc:5.x Jul 25, 2022
@AA-Turner AA-Turner added this to the 5.1.1 milestone Jul 25, 2022
AA-Turner pushed a commit that referenced this pull request Jul 25, 2022
There's some parts of the code still expecting a StopIteration instead.
@anntzer anntzer deleted the nn branch July 26, 2022 00:40
matthewfeickert added a commit to scikit-hep/pyhf that referenced this pull request Jul 26, 2022
…que' (#1925)

* Disallow Sphinx v5.1.0 as it introduces an deque error that can be
  caused by sphinx.ext.napoleon:
> Extension error (sphinx.ext.napoleon):
> Handler <function _process_docstring at 0x7f43e8361a20> for event 'autodoc-process-docstring'
> threw an exception (exception: pop from an empty deque)
   - This was fixed rapidly in sphinx-doc/sphinx#10709 and
     so will not be a problem in Sphinx v5.1.1+.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sphinx 5.1.0 exception: pop from an empty deque
2 participants