Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Node.findall() from Node.traverse() #10044

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Jan 1, 2022

Feature or Bugfix

  • Refactoring

Purpose

  • Node.traverse() was marked as deprecated since docutils-0.18. Instead
    of it, Node.findall() has been added as successor of traverse().
  • This applies a patch to docutils-0.17 or older to be available
    Node.findall() and use it.
  • refs: Update Sphinx to work with docutils-0.18.x #9777

@tk0miya tk0miya added internals:refactoring docutils Tags upstream Docutils issues labels Jan 1, 2022
@tk0miya tk0miya added this to the 4.4.0 milestone Jan 1, 2022
@tk0miya tk0miya force-pushed the 9777_Node.findall branch 5 times, most recently from 4a15b30 to 8b718c0 Compare January 2, 2022 15:17
Node.traverse() was marked as deprecated since docutils-0.18.  Instead
of it, Node.findall() has been added as successor of traverse().

This applies a patch to docutils-0.17 or older to be available
Node.findall() and use it.
@tk0miya tk0miya merged commit 08a87d9 into sphinx-doc:4.x Jan 2, 2022
@tk0miya tk0miya deleted the 9777_Node.findall branch January 2, 2022 15:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docutils Tags upstream Docutils issues internals:refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant