Introduce confluence api token option #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following introduces the option `confluence_api_token` to this extension. The goal is somewhat of a replacement of the option `confluence_server_pass`. For Confluence Cloud, API tokens are required for authentication. For Confluence Data Center, PATs are preferred although there may be some level of support for passwords. The option `confluence_server_pass` was one of the original options introduced by this extension. Over the years there has been a transition towards tokens, so a rename may be best. Specifically, there seem to be cases where people place API tokens in the personal access token (PAT) option but should have been under the "pass" option. Having the option explicitly say "API token" should provide some clarify. Note that `confluence_api_token` should be functionally the same as using `confluence_server_pass`, so existing environments should not require any immediate changes. Over time, `confluence_server_pass` may be deprecated. Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following introduces the option
confluence_api_tokento this extension. The goal is somewhat of a replacement of the optionconfluence_server_pass. For Confluence Cloud, API tokens are required for authentication. For Confluence Data Center, PATs are preferred although there may be some level of support for passwords.The option
confluence_server_passwas one of the original options introduced by this extension. Over the years there has been a transition towards tokens, so a rename may be best. Specifically, there seem to be cases where people place API tokens in the personal access token (PAT) option but should have been under the "pass" option. Having the option explicitly say "API token" should provide some clarify.Note that
confluence_api_tokenshould be functionally the same as usingconfluence_server_pass, so existing environments should not require any immediate changes. Over time,confluence_server_passmay be deprecated.