Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept path-like configuration options #888

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Accept path-like configuration options #888

merged 2 commits into from
Feb 26, 2024

Commits on Feb 26, 2024

  1. adjust file/path-related options to accept path-like values 

    For various configuration options, sanity checks for path-related
options would require values to be string values. If a user defined
these values using PathLib, a configuration exception would be thrown
(and a user would have to workaround by explicitly str-casting the
values). To be flexible for these configurations, ensure all
path-related options can accept both `str` or `os.PathLike` typed
entries.

Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    d65f901 View commit details
    Browse the repository at this point in the history

  2. tests: remove unnecessary str-casting for path options 

    A series of configuration options prepared with pathlib and passed into
configuration checks (and more) had to be str-casted to ensure the
checks would not trigger an unexpected error. Since support has been
added into this extension to accept both str and path-like types,
removing the unnecessary casting.

Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    72c52fe View commit details
    Browse the repository at this point in the history