Update development scripts/testing to include Sphinx v8.x #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuring a minimum version of Sphinx to v7.1.x. We only support up to five major-minor versions of Sphinx, and with Sphinx v8 released, setting a new lowest version. This should prevent any issues from arising for versions we no longer actively test on. Signed-off-by: James Knight <james.d.knight@live.com>
Most recent work only aims to support v7.1+ series. See CONTRIBUTING.md for additional information. Signed-off-by: James Knight <james.d.knight@live.com>
Most recent work only aims to support v7.1+ series. See CONTRIBUTING.md for additional information. Signed-off-by: James Knight <james.d.knight@live.com>
Sphinx provides a stable v8.0.x series; adjusting the tox configuration to support the new revision. Following maintenance guidelines, this allows a series of legacy Sphinx revisions to be dropped as well. See CONTRIBUTING.md for additional information. Signed-off-by: James Knight <james.d.knight@live.com>
Avoid the need to duplicate a requirements include that could instead be inherited from the base environment. Signed-off-by: James Knight <james.d.knight@live.com>
Updating the check helper to use the most recent version of Sphinx. Signed-off-by: James Knight <james.d.knight@live.com>
The tox configuration has been adjusted with a new version of Sphinx versions to test against. Adjusting the automated building to invoke these accordingly. Signed-off-by: James Knight <james.d.knight@live.com>
| @@ -19,7 +19,7 @@ | |||
| supported_confluence_ver = '7.19+' | |||
| supported_python_ver = '3.8+' | |||
| supported_requests_ver = '2.25.0+' | |||
| supported_sphinx_ver = '6.1+' | |||
| supported_sphinx_ver = '7.1+' | |||
There was a problem hiding this comment.
@jdknight Hi, the pyproject.toml still requires Sphinx>=6.1, which can break installations, as sphinxcontrib-confluencebuilder is upgrade to 2.7 without bumping Sphinx to 7.1.
See the error below.
Sphinx version error:
The sphinxcontrib.confluencebuilder extension used by this project needs at least Sphinx v7.1; it therefore cannot be built with this version.
There was a problem hiding this comment.
@robert-schmidtke, thanks for the report. Should be addressed in the v2.7.1 release.
There was a problem hiding this comment.
Thanks for resolving this so quickly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the tox environment, GitHub actions and other tweaks to include Sphinx v8 series into this repository.