Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename mem fs with descendants #364

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

hanagantig
Copy link
Contributor

fix for issue #141
Please check it. This bug needs to be fixed.

@CLAassistant
Copy link

CLAassistant commented Jun 25, 2022

CLA assistant check
All committers have signed the CLA.

@hanagantig hanagantig force-pushed the mem-rename-descendants branch from 12dc3ca to 240745d Compare June 25, 2022 11:58
@hanagantig hanagantig force-pushed the mem-rename-descendants branch 2 times, most recently from a0c52d4 to 51b1016 Compare June 25, 2022 13:26
@hanagantig hanagantig force-pushed the mem-rename-descendants branch from 72b314f to 687caf6 Compare May 6, 2023 10:25
@hanagantig
Copy link
Contributor Author

@bep hi, this is an old pull request for #141 issue.
I updated the branch and resolved conflicts. If you have time could you look at it please, it would be appreciated.

@hanagantig
Copy link
Contributor Author

@bep any comments or suggestions here please

@bep
Copy link
Collaborator

bep commented Sep 7, 2023

@hanagantig sorry for the delay; this looks correct, but it needs to be rebased with master. If you do that and ping me again, I will merge.

@hanagantig hanagantig force-pushed the mem-rename-descendants branch from 687caf6 to 00197d9 Compare September 7, 2023 17:54
@hanagantig
Copy link
Contributor Author

@bep Thanks a lot. I just pushed it without merge commits. Could you please have a look?

@bep
Copy link
Collaborator

bep commented Sep 8, 2023

@hanagantig there's a staticcheck error there that should be easy to fix.

@hanagantig hanagantig force-pushed the mem-rename-descendants branch from 00197d9 to 58e224c Compare September 8, 2023 14:19
@hanagantig
Copy link
Contributor Author

@bep unnecessary assignment static check error fixed

@hanagantig
Copy link
Contributor Author

hanagantig commented Sep 11, 2023

@bep can we merge it please ?

@hanagantig
Copy link
Contributor Author

@bep your attention is required. Could you please proceed with checks ?

@bep bep merged commit ee6eef7 into spf13:master Sep 22, 2023
9 checks passed
@hanagantig
Copy link
Contributor Author

@bep thank you so much 🙏

nono referenced this pull request in cozy/cozy-stack Sep 25, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/spf13/afero](https://togithub.com/spf13/afero) | require |
minor | `v1.9.5` -> `v1.10.0` |

---

### Release Notes

<details>
<summary>spf13/afero (github.com/spf13/afero)</summary>

### [`v1.10.0`](https://togithub.com/spf13/afero/releases/tag/v1.10.0)

[Compare
Source](https://togithub.com/spf13/afero/compare/v1.9.5...v1.10.0)

#### What's Changed

- Add sftpfs files ReadAt method by
[@&#8203;MRtecno98](https://togithub.com/MRtecno98) in
[https://github.com/spf13/afero/pull/378](https://togithub.com/spf13/afero/pull/378)
- Add build flags for z/OS Unix System Services by
[@&#8203;msradam](https://togithub.com/msradam) in
[https://github.com/spf13/afero/pull/384](https://togithub.com/spf13/afero/pull/384)
- rename mem fs with descendants by
[@&#8203;hanagantig](https://togithub.com/hanagantig) in
[https://github.com/spf13/afero/pull/364](https://togithub.com/spf13/afero/pull/364)

#### New Contributors

- [@&#8203;MRtecno98](https://togithub.com/MRtecno98) made their first
contribution in
[https://github.com/spf13/afero/pull/378](https://togithub.com/spf13/afero/pull/378)
- [@&#8203;msradam](https://togithub.com/msradam) made their first
contribution in
[https://github.com/spf13/afero/pull/384](https://togithub.com/spf13/afero/pull/384)
- [@&#8203;hanagantig](https://togithub.com/hanagantig) made their first
contribution in
[https://github.com/spf13/afero/pull/364](https://togithub.com/spf13/afero/pull/364)

**Full Changelog**:
spf13/afero@v1.9.5...v1.10.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone
Europe/Paris, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cozy/cozy-stack).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants