Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create submodules for ecc and aionostr #9100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ecdsa
Copy link
Member

@ecdsa ecdsa commented Jun 20, 2024

The ecc submodule is there twice:

  • electrum/ecc
  • electrum/aionostr/ecc

The install script copies libsecp256k1.so.2 in only one of them.
That seems to be enough, because of the way loadLibrary works.
However, we might forget about that. Should we copy it twice instead?`

@ecdsa
Copy link
Member Author

ecdsa commented Jun 20, 2024

aionostr uses the websockets package.
apparently, that package does not work with a proxy.
https://stackoverflow.com/questions/47225488/client-websocket-connect-through-proxy
maybe we could use websocket-client instead.

@accumulator
Copy link
Member

accumulator commented Jun 20, 2024

The ecc submodule is there twice:

* electrum/ecc

* electrum/aionostr/ecc

The submodule paths could be added to the python interpreter search path, similar to what is done in run_electrum:

if is_local or is_android:
    sys.path.insert(0, os.path.join(script_dir, 'packages'))

There should be no need for a copy in electrum/aionostr/ecc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants