Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onion messages #9039

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

onion messages #9039

wants to merge 10 commits into from

Conversation

accumulator
Copy link
Member

No description provided.

@accumulator accumulator mentioned this pull request May 6, 2024
Closed
@accumulator accumulator force-pushed the onion_messages branch 2 times, most recently from 693e836 to 8c707dc Compare May 10, 2024 13:16
@accumulator
Copy link
Member Author

this branch is now onion_messages only, all bolt12 stuff has been moved to the bolt12 branch, which builds on top of this branch/PR

@accumulator accumulator force-pushed the onion_messages branch 2 times, most recently from 4ce8580 to 9c4bec1 Compare June 6, 2024 12:08
@accumulator accumulator force-pushed the onion_messages branch 5 times, most recently from d7d81e9 to 20b8bd9 Compare July 3, 2024 16:40
@accumulator accumulator changed the title onion messages wip onion messages Jul 3, 2024
@accumulator accumulator marked this pull request as ready for review July 3, 2024 16:58
@accumulator
Copy link
Member Author

accumulator commented Jul 3, 2024 •
edited
Loading

@ecdsa, @SomberNight, this PR is getting ready to be reviewed.

  • I have successfully sent onion messages across electrum instances Alice <-> Bob <-> Carol <-> Dave using node_ids and blinded paths as destination.
  • added CLI commands
    • get_blinded_path_via to construct a blinded path (only via a direct peer currently, but longer routes should be trivial to add)
    • send_onion_message to send a text onionmsg_tlv.message payload to a node_id or blinded path (destination node will log these on info level)
  • route finding over onion message capable nodes using channels as edges (however not yet tested outside unit-tests as regtest with only electrum nodes lacks a channel graph)
  • initial OnionMessageManager class implementing a send queue which should match replies to requests, rate-limiting, alternate route retries in case no reply within x seconds etc. (not needed for text onionmsg_tlv.message payloads, but eventually bolt12 will need this)
  • serialization and deserialization of subtype declarations in wire definitions
  • TODOs added where applicable
  • Of note, there's extra variants of new_onion_packet and get_shared_secrets_along_route that need to be unified..

@accumulator
lnwire: add msg and tlv types for onion_message, including unknown_ta…
a9adccb 
…gs for test vectors
@accumulator
onion_wire: use unqualified byte,... type for yet undefined nested tl…
db98e6e 
…v types
@accumulator
lnonion: new_onion_packet2, get_shared_secrets_along_route2
7890899 
move optional params to process_onion_packet to kwargs, add tlv_stream_name param
pass tlv_stream_name to OnionHopsDataSingle.from_fd()
store proper tlv_stream_name in OnionHopsDataSingle when reading from fd
@accumulator
lnmsg: additional de/serialization support for onion messages
48b2fd3 
- add support for `subtype`/`subtypedata` type declarations
- add new primitive type `sciddir_or_pubkey`
@accumulator
lnutil: add onion message feature flag
502be4d
@accumulator
util: define now()
9398d09
@accumulator
onion_message: create onion_message.py
c38ba15 
commands: add send_onion_message, get_blinded_path_via
lnworker: add OnionMessageManager to lnworker
lnrouter: add node filter to LNPathFinder
SomberNight
SomberNight reviewed Jul 10, 2024
View reviewed changes
electrum/lnmsg.py Outdated Show resolved Hide resolved
SomberNight
SomberNight reviewed Jul 10, 2024
View reviewed changes
electrum/lnpeer.py Outdated Show resolved Hide resolved
@accumulator accumulator force-pushed the onion_messages branch 2 times, most recently from fce6b5c to 7bb7596 Compare July 17, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomberNight SomberNight SomberNight left review comments

@Onnielassy28 Onnielassy28 Onnielassy28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@accumulator @SomberNight @Onnielassy28