Qt AddressList: mark address if some coins are frozen #8040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some coins are frozen in the wallet (but not addresses), the Addresses tab of the Qt GUI does not give any clues to the user about this. I think if there is an address which is not frozen itself but some related UTXOs are, the interface should show that somehow.
I don't know how to do it nicely though... In this PR, as before, a frozen address has a solid blue background colour; and now if there are some frozen coins, the address has a background in a different style.
related: #8035 (comment)
I've done some benchmarking on large wallets, and this makes
AddressList.refresh_all()
around 2x slower.(due to calculating the utxos for an address:
wallet.adb.get_addr_utxo(address)
)Regardless, I think the slowdown is acceptable.