Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main clause determination #1072

Conversation

ryancasburn-KAI
Copy link
Contributor

Fixes #1071

I wasn't sure if you would want this pull request on master or dev. Let me know if you want me to change it.

This has two main updates:

  1. Change subordinating conjunctions to only match at the beginning of the clause.

"He collaborated with the university to develop comprehensive academic proposals throughout the entire campus, encompassing academic priorities in every department at the university and course structure typologies for each academic program." The word throughout in the first clause should not eliminate it from the main clause determination.

  1. Add check for clauses starting with gerund.

"Taking diligent notes throughout the entire class, the students remained focused during the lecture." Both clauses have a verb, and nothing else to eliminate them. However, starting with a gerund should eliminate the first clause.

@ryancasburn-KAI
Copy link
Contributor Author

I'm wondering if all the subordinate (and maybe relative) list should also be constrained to start of clause only?

  • She has since led two projects, including a project in Australia.
  • She has since it is cool.
  • She has, since it is cool.
  • Since he cares about his health, he has eaten carrots since birth.

@spencermountain spencermountain changed the base branch from master to dev January 3, 2024 20:57
@spencermountain
Copy link
Owner

beauty! Thank you Ryan, I've been hoping that this method would get some love, at some point.
Please take the wheel, and make any changes you'd like. I'm all in!

Also, i love the idea of debugging via gpt. Such a fine use of a LLM, to test assumptions like that.

If mainClause ever starts working reliably well, the features we could add to .sentence() would be incredible.
cheers

@spencermountain spencermountain merged commit f92b993 into spencermountain:dev Jan 3, 2024
@ryancasburn-KAI
Copy link
Contributor Author

Great, glad I can help! My main use case at the moment is identifying if a sentence is written in present tense, so identifying the correct verb is important. I will continue to explore how this can be made better 😃

@spencermountain spencermountain mentioned this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Throughout" within a main clause currently doesn't work.
3 participants