Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noun-phrase toSingular() issue #921

Closed
spencermountain opened this issue May 26, 2022 · 2 comments
Closed

noun-phrase toSingular() issue #921

spencermountain opened this issue May 26, 2022 · 2 comments
Assignees
@spencermountain
Labels
bug fixed-on-dev

Comments

@spencermountain
Copy link
Owner

spencermountain commented May 26, 2022 •
edited
Loading

from #862 via @jfemia

let doc = nlp('Maris Piper potatoes')
doc.nouns().toSingular()
doc.debug()
//'Maris Piper potatoes'
@spencermountain spencermountain changed the title noun-phrase toSingular() noun-phrase toSingular() issue May 26, 2022
@spencermountain spencermountain self-assigned this May 26, 2022
spencermountain added a commit that referenced this issue May 26, 2022
@spencermountain
fix for #921
bf09020
@jfemia
Copy link
Contributor

jfemia commented May 26, 2022

Hey Spencer, thanks so much for taking the time to look into this and for being an all-round awesome, helpful fellow!

@spencermountain spencermountain mentioned this issue Jun 1, 2022
Merged
@spencermountain
Copy link
Owner Author

this is fixed now in 14.2.0
https://runkit.com/spencermountain/6297b979d280f000082effea
cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spencermountain spencermountain

Labels
bug fixed-on-dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spencermountain @jfemia