Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future-proof conditional compilation #563

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Sep 29, 2021

  • Invert #if NET5_0 conditions so that when adding net6.0 target framework, the new APIs are used.
  • Use NET5_0_OR_GREATER instead of NET5_0 to ensure consistent behaviour on future target frameworks.

* Invert `#if NET5_0` conditions so that when adding net6.0 target framework, the _new_ APIs are used.
* Use `NET5_0_OR_GREATER` instead of `NET5_0` to ensure consistent behaviour on future target frameworks.
Copy link
Contributor

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@patriksvensson patriksvensson merged commit a5716a3 into spectreconsole:main Sep 29, 2021
@0xced 0xced deleted the future-proof branch September 29, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants