Include resource files for additional cultures in HelpProvider.

[Tolitech]

As discussed in #1349 (@FrankRay78), I am adding 6 new resource files to enable the HelpProvider to display information in the following new cultures: it, ja, ko, pt, ru, zh-Hans.

• I have read the Contribution Guidelines
• I have commented on the issue above and discussed the intended changes
• A maintainer has signed off on the changes and the issue was assigned to me
• All newly added code is adequately covered by tests
• All existing tests are still running without errors
• The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

I have only added 6 new resource files to the CLI project, without making any changes to the existing code. These additions simply ensure that the HelpProvider will display information in the configured culture.

The added cultures are:
Italian (it), Japanese (ja), Korean (ko), Portuguese (pt), Russian (ru), and Chinese (zh-Hans).

---

Please upvote 👍 this pull request if you are interested in it.

[Tolitech]

@microsoft-github-policy-service agree

[patriksvensson]

@FrankRay78 We would need to verify that the translations are correct.

[FrankRay78]

I was thinking we could put them through some translation websites/tools, just to make sure it didn't say 'I love dogs' or something like that.

Are you a native speaker of these six languages @Tolitech?

[Tolitech]

Hello, @FrankRay78 ,
I completely understand your concern.

I am from Brazil, where we speak Portuguese, which is my native language.

The other languages were translated from English into their respective languages using artificial intelligence tools. I believe the results and adaptations are more reliable than those from traditional translation tools.

If we perform a reverse translation of these languages back into English, we can see that the translations are valid and accurate, and not intended as any sort of "joke."

That said, I understand and respect your concern—it is indeed a valid one.

If there is any way I can demonstrate to you that my intentions are genuine, please rest assured that I am more than willing to do so.

For reference, I was able to contribute to the MudBlazor project (translations to pt-BR) through the link below:
https://hosted.weblate.org/projects/mudblazor/

Despite the low adoption/use and confirmation by other users.

I believe the easiest way to prove the legitimacy of the information would be to open the .resx file, copy and paste the translated column, and ask, for example, an artificial intelligence tool to translate from culture "xx" to "en" (reverse translation).

This way, we would quickly see that there are no random texts provided.

Whatever you decide regarding this Pull Request will be fine with me.

[FrankRay78]

@Tolitech Thanks for the explanation. It's not the most complex translation, so I'm keen to move forward. I'll take a closer look at this over the coming days and let you know. I'm going to be a little quiet over the holiday season. Be well, in the meantime.

[Tolitech]

@FrankRay78
Thank you so much for your response! I really appreciate your time and consideration. I completely understand the need to take a closer look, and I’m happy to wait until you have the chance to review it. Wishing you a wonderful holiday season filled with joy and relaxation. Take care, and I look forward to hearing from you soon!

[FrankRay78]

Hello @Tolitech, the consensus amongst the maintainers seems to be for a native speaker to approve these translations. The good news is that I have a big enough social network that I should be able to find a native speaker for each translation.

To facilitate that in the best possible manner, I'd like a unit test expectation for each, that demonstrates the translation in place.

See the following as an example for DE:

https://github.com/spectreconsole/spectre.console/blob/main/src/Tests/Spectre.Console.Cli.Tests/Expectations/Help/Default_Without_Args_Additional.Output_DE.verified.txt

And they are added into the test suite here:

spectre.console/src/Tests/Spectre.Console.Cli.Tests/Unit/CommandAppTests.Help.cs

Line 307 in 58bf89a

public Task Should_Output_Default_Command_And_Additional_Commands_When_Default_Command_Has_Required_Parameters_And_Is_Called_Without_Args_Localised(string culture, string expectationPrefix)

If you can do that and update the PR, I will then seek the appropriate confirmations.

[Tolitech]

Hello @FrankRay78,
I hope you had a wonderful end of the year.

Created six test files in Expectations\Help for the following cultures:

• Default_Without_Args_Additional.Output_IT.verified.txt
• Default_Without_Args_Additional.Output_JA.verified.txt
• Default_Without_Args_Additional.Output_KO.verified.txt
• Default_Without_Args_Additional.Output_PT.verified.txt
• Default_Without_Args_Additional.Output_RU.verified.txt
• Default_Without_Args_Additional.Output_ZH-HANS.verified.txt

Updated CommandAppTests.Help.cs with InlineData for:

• Italian (IT): "it", "it-IT"
• Japanese (JA): "ja", "ja-JP"
• Korean (KO): "ko", "ko-KR"
• Portuguese (PT): "pt", "pt-BR"
• Russian (RU): "ru", "ru-RU"
• Simplified Chinese (ZH-HANS): "zh-Hans", "zh-Hans-CN"

[FrankRay78]

Thank you @Tolitech, leave it with me. I'll put it out to my network next week.

[FrankRay78]

Update - pt and it have now been validated, others pending.

Stupidly, I've noticed that I didn't originally include the version switch in the help output in this set of unit tests (ie '--version to show the application version') so they haven't been validated. An issue for another day I think.

[Tolitech]

Hello, @FrankRay78,

You are absolutely correct; the test is indeed missing the configuration to specify the version of the 'giraffe' app.
When adding the code configurator.SetApplicationVersion("1.0.0"), it is natural that all tests will start failing, including those for the existing languages, such as English, French, Swedish, and German.

If you prefer, I can include the configurator.SetApplicationVersion("1.0.0") configuration and update the output files in this same PR, covering all cultures, both new and existing.

In fact, I have already done it locally, as it is a 1-minute change.
I just don’t know if you would like me to push these changes in this same PR.

Just a reminder, this change affects the output files for the existing cultures: en, fr, sv, and de.

[FrankRay78]

Hello @Tolitech

As much as I would love to just ignore the oversight, as a maintainer I should really fix it...

In fact, I have already done it locally, as it is a 1-minute change.

Thank you!

I just don’t know if you would like me to push these changes in this same PR.

Yes, please do push the changes.

Just a reminder, this change affects the output files for the existing cultures: en, fr, sv, and de.

Noted - I will need to get these reviewed as well.

But even if it takes a little longer, the PR will be a good one when it's finally merged.

Thanks,
Frank

[Tolitech]

Update to the file CommandAppTests.Help.cs to include the app version for 'giraffe'.

As a result, the following files were also updated to display the --version option:

Expectations\Help:

Default_Without_Args_Additional.Output_DE.verified.txt
Default_Without_Args_Additional.Output_EN.verified.txt
Default_Without_Args_Additional.Output_FR.verified.txt
Default_Without_Args_Additional.Output_IT.verified.txt
Default_Without_Args_Additional.Output_JA.verified.txt
Default_Without_Args_Additional.Output_KO.verified.txt
Default_Without_Args_Additional.Output_PT.verified.txt
Default_Without_Args_Additional.Output_RU.verified.txt
Default_Without_Args_Additional.Output_SV.verified.txt
Default_Without_Args_Additional.Output_ZH-HANS.verified.txt

[FrankRay78]

FYI. I'm having trouble finding reviewers, even though my LinkedIn network is substantial.

[patriksvensson]

@FrankRay78 Let's do a quick sanity check using google translate or similar and get it merged.