Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing documentation #1631

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

FrankRay78
Copy link
Contributor

@FrankRay78 FrankRay78 commented Sep 5, 2024

The following PR spectreconsole/examples#2 should be reviewed/merged at the same time as this one.


fixes #1410

Addresses:


  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

  • Wrote an entirely new documentation page for Unit Testing
  • Updated site index and best practices with unit testing content
  • Added Spectre.Console.Testing namespace to generated API docs
  • Minor grammar improvements

Please upvote 👍 this pull request if you are interested in it.

@FrankRay78 FrankRay78 self-assigned this Sep 5, 2024
@FrankRay78 FrankRay78 marked this pull request as draft September 5, 2024 11:56
@FrankRay78 FrankRay78 added this to the 0.50 milestone Sep 5, 2024
@FrankRay78 FrankRay78 mentioned this pull request Sep 5, 2024
6 tasks
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Sep 6, 2024
@FrankRay78 FrankRay78 changed the title Add testing documentation (second attempt by maintainer) DRAFT Add testing documentation DRAFT Sep 7, 2024
@FrankRay78 FrankRay78 force-pushed the Testing-documentation branch from 5f5a385 to c738d75 Compare September 10, 2024 13:39
@FrankRay78 FrankRay78 changed the title Add testing documentation DRAFT Add testing documentation Sep 16, 2024
@FrankRay78 FrankRay78 marked this pull request as ready for review September 16, 2024 20:19
@FrankRay78 FrankRay78 requested a review from a team September 16, 2024 20:21
@FrankRay78 FrankRay78 force-pushed the Testing-documentation branch from 8722ac1 to 5b613c0 Compare September 17, 2024 10:14
Co-authored-by: csc530 <77406318+csc530@users.noreply.github.com>
@FrankRay78
Copy link
Contributor Author

This one's ready for review.

IMPORTANT: The following PR spectreconsole/examples#2 should be reviewed/merged at the same time as this one.

@github-actions github-actions bot added ⭐ top pull request Top pull request. and removed ⭐ top pull request Top pull request. labels Nov 4, 2024
@patriksvensson patriksvensson modified the milestones: 0.50, 0.51 Nov 13, 2024
@github-actions github-actions bot removed the ⭐ top pull request Top pull request. label Nov 14, 2024
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: PR 📬
Development

Successfully merging this pull request may close these issues.

Testing documentation
2 participants