Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add denoising methods to class PrincipalComponents #91

Merged
merged 3 commits into from
Aug 19, 2019

Conversation

gemmaellen
Copy link
Contributor

Hi there!

I wrote a couple of denoising methods into the PrincipalComponents class, with a format similar to the ones in the MNFResult class. I'm currently using MNF on some data I'm working on, and I find it useful to be able to swiftly compare the MNF denoising to an equivalent PCA denoising.

This is my first ever pull request, just so you know, so I hope I'm going about this in basically the right way. Tips are welcome.

Thanks!
--Gemma

@gemmaellen
Copy link
Contributor Author

It looks like the checks aren't failing because of anything I did -- I've run them on an unaltered branch and they fail there, too, in the exact same way. I think the issue is this one:

https://travis-ci.community/t/issue-with-python-2-6-on-linux/3861

The suggested fix of adding dist: trusty to the travis.yml file works. I'm not sure if this is the actual fix you wish to implement, or if you want to no longer support Python 2.6 and Python 3.3, instead.

@tboggs
Copy link
Member

tboggs commented Aug 19, 2019

Hi Gemma,

Thanks for the addition! I'll accept the merge request shortly

Also, I'm long overdue for pushing out an updated release so I'll try to get that done within the next week or so.

Thanks,
Thomas

@tboggs tboggs merged commit fc41f94 into spectralpython:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants