Fix Event.emit type error for enums #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust enums are represented in TS as a type union. For some reason,
T extends null
collapses the type into an intersection, which makes it a type error to callSomeEvent.emit(x)
for any value x. That may be a TypeScript error—I'm still investigating. In the meantime, this patch avoids the issue.Here's a minimal example to try in the typescript playground. The definition of
__EventObj__
is as it is before my patch.