Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First Pass adding the newer DefaultTraversal #367

Open
wants to merge 1 commit into
base: v3-dev
Choose a base branch
from

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Dec 11, 2024

Added the DefaultTraversal that C# has been enjoying. (added by specklesystems/speckle-sharp#3327)

Reminder about what it is, its the new v3 de-facto rules to consume "convertible" objects in the tree.

It has been designed in a way that behaves for all intents and purposes, the same as the traversal logic in v2, but decoupled from the CanConvertToNative function that the old v2 function depended on.

Its what we should use when consuming objects in our v3 connectors.


Tested with Blender connector (tho I'm not going to update blender until we do a v3)
I haven't done any unit tests for this DefaultTraversal, beyond the general ones for the GraphTraversal, since we don't have any in C#, but perhaps we should...

Copy link

linear bot commented Dec 11, 2024

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.84%. Comparing base (9039515) to head (fb78e96).
Report is 16 commits behind head on v3-dev.

Files with missing lines Patch % Lines
src/specklepy/objects/graph_traversal/traversal.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           v3-dev     #367      +/-   ##
==========================================
+ Coverage   89.67%   89.84%   +0.17%     
==========================================
  Files         123      124       +1     
  Lines        6685     6729      +44     
==========================================
+ Hits         5995     6046      +51     
+ Misses        690      683       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan JR-Morgan changed the base branch from v3-dev to main December 12, 2024 12:55
@JR-Morgan JR-Morgan changed the base branch from main to v3-dev December 12, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant