Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(automate): remove extra slash #346

Merged
merged 1 commit into from
Aug 11, 2024
Merged

fix(automate): remove extra slash #346

merged 1 commit into from
Aug 11, 2024

Conversation

cdriesler
Copy link
Member

Description & motivation

  • Calls of automate_context.store_file_result() would fail for functions with the following error:
Client error '404 Not Found' for url 'https://latest.speckle.systems//api/stream/<streamId>/blob'
  • This is because automation_run_data.speckle_server_url was being set with a trailing slash by Automate (e.g. https://latest.speckle.systems/) and the sdk appends /api/stream to that.

Changes:

  • Changes url construction here (instead of Automate)

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.65%. Comparing base (905377d) to head (078a6c8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   87.65%   87.65%           
=======================================
  Files          95       95           
  Lines        5670     5670           
=======================================
  Hits         4970     4970           
  Misses        700      700           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gjedlicska
Copy link
Collaborator

🤦

@gjedlicska gjedlicska self-requested a review August 11, 2024 11:31
@gjedlicska gjedlicska merged commit fe03d96 into main Aug 11, 2024
5 checks passed
@gjedlicska gjedlicska deleted the charles/trailingSlash branch August 11, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants