Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default domain): app.speckle.systems is now default over speckle.xyz #343

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Jul 18, 2024

Description & motivation

The new default domain for Speckle is app.speckle.systems. We are in the process of deprecating speckle.xyz

https://linear.app/speckle/project/deprecate-fe1-47acf8176ef9/overview

Changes:

  • also updates the example email domain to use the IANA owned example domain instead of a production or random domain

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

….xyz

- also updates the example email domain to use the IANA owned example domain instead of a production or random domain
Copy link

gitguardian bot commented Jul 18, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
5405539 Triggered Generic Password cf2ac58 tests/integration/conftest.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.65%. Comparing base (62c5114) to head (cf2ac58).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   87.65%   87.65%           
=======================================
  Files          95       95           
  Lines        5670     5670           
=======================================
  Hits         4970     4970           
  Misses        700      700           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iainsproat iainsproat marked this pull request as ready for review July 18, 2024 12:10
@JR-Morgan JR-Morgan merged commit 905377d into main Jul 18, 2024
5 checks passed
@JR-Morgan JR-Morgan deleted the iain/update-default-host branch July 18, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants