Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in properties.py #253

Conversation

RobClaessensRHDHV
Copy link
Contributor

@RobClaessensRHDHV RobClaessensRHDHV commented Jan 16, 2023

Fix: Typo fix of STRUCTURAL PROPERTY variable in https://github.com/specklesystems/specklepy/blob/main/src/specklepy/objects/structural/properties.py#L8

Description & motivation

Tiny bug with big consequences. All property objects will not be properly recognized and will be deserialized to a Base object. This gives issues in further conversion for our case, where we convert an analytical Revit model from Speckle to Python.

Changes:

Fix typo

To-do before merge:

Nothing, as far as I can see, small patch would be much appreciated! :)

Validation of changes:

Fixed the typo locally, which allows me to convert a full structural model from Speckle to Python. I tested with a stream of an analytical Revit model used in of your tutorials: https://speckle.xyz/streams/bf8c36d0d2/commits/68269d458f

-->

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 91.19% // Head: 91.19% // No change to project coverage 👍

Coverage data is based on head (7e1bec1) compared to base (1fb9a4f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files          65       65           
  Lines        4439     4439           
=======================================
  Hits         4048     4048           
  Misses        391      391           
Impacted Files Coverage Δ
src/specklepy/objects/structural/properties.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RobClaessensRHDHV
Copy link
Contributor Author

Small but necessary fix, @gjedlicska

@gjedlicska
Copy link
Collaborator

Thanks. 🙇🏽

@gjedlicska gjedlicska merged commit e842f65 into specklesystems:main Jan 16, 2023
@RobClaessensRHDHV RobClaessensRHDHV deleted the feature/structural_property_bugfix branch January 16, 2023 13:02
@RobClaessensRHDHV
Copy link
Contributor Author

I do have some additional small changes that are required to receive the Revit model. Will make an additional PR with that later.
So if you're planning to patch, you could wait for that, will wrap it up this afternoon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants