Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Typo fix of
STRUCTURAL PROPERTY
variable in https://github.com/specklesystems/specklepy/blob/main/src/specklepy/objects/structural/properties.py#L8Description & motivation
Tiny bug with big consequences. All property objects will not be properly recognized and will be deserialized to a
Base
object. This gives issues in further conversion for our case, where we convert an analytical Revit model from Speckle to Python.Changes:
Fix typo
To-do before merge:
Nothing, as far as I can see, small patch would be much appreciated! :)
Validation of changes:
Fixed the typo locally, which allows me to convert a full structural model from Speckle to Python. I tested with a stream of an analytical Revit model used in of your tutorials: https://speckle.xyz/streams/bf8c36d0d2/commits/68269d458f
-->