Merge pull request #485 from specklesystems/dimitrie/cnx-124-conversi…

…on-of-areas-and-rooms-cannot-handle-more-complex fix: ignoring extra categories we cannot support correctly
specklesystems · Jan 10, 2025 · c1c8b64 · c1c8b64
2 parents e955617 + 49ef7d1
commit c1c8b64
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/Connectors/Revit/Speckle.Connectors.RevitShared/HostApp/SupportedCategoriesUtils.cs b/Connectors/Revit/Speckle.Connectors.RevitShared/HostApp/SupportedCategoriesUtils.cs
@@ -16,6 +16,14 @@ public static bool IsSupportedCategory(Category category)
     return (
         category.CategoryType == CategoryType.Model
       // || category.CategoryType == CategoryType.AnalyticalModel
-      ) && category.IsVisibleInUI;
+      )
+#if REVIT_2023_OR_GREATER
+      && category.BuiltInCategory != BuiltInCategory.OST_AreaSchemes
+      && category.BuiltInCategory != BuiltInCategory.OST_AreaSchemeLines
+#else
+      && category.Name != "OST_AreaSchemeLines"
+      && category.Name != "OST_AreaSchemes"
+#endif
+      && category.IsVisibleInUI;
   }
 }
diff --git a/...eckle.Converters.RevitShared/ToSpeckle/TopLevel/RevitElementTopLevelConverterToSpeckle.cs b/...eckle.Converters.RevitShared/ToSpeckle/TopLevel/RevitElementTopLevelConverterToSpeckle.cs
@@ -81,6 +81,9 @@ public RevitObject Convert(DB.Element target)
       }
       catch (ValidationException)
       {
+        // NOTE: i've improved the if check above to make sure we never reach here
+        // we were throwing a lot here for various elements (e.g. floors) and we would
+        // be slowing things down
         // location was not a supported, do not attach to base element
       }
     }