Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup install dependencies #197

Merged
merged 1 commit into from
May 24, 2024

Conversation

overengineer
Copy link
Contributor

Reduced time of install_requirements on startup from about ~12 seconds to ~7 seconds by using pip options.

@overengineer overengineer marked this pull request as ready for review May 21, 2024 16:56
@JR-Morgan JR-Morgan self-requested a review May 24, 2024 15:35
@JR-Morgan JR-Morgan self-assigned this May 24, 2024
@JR-Morgan JR-Morgan added the enhancement New feature or request label May 24, 2024
Copy link
Member

@JR-Morgan JR-Morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Cheers!

@JR-Morgan JR-Morgan merged commit 8e3c2ec into specklesystems:main May 24, 2024
1 check passed
@JR-Morgan JR-Morgan added this to the 2.19 milestone May 24, 2024
@overengineer
Copy link
Contributor Author

@JR-Morgan Can we skip dependency checks entirely if the addon is already installed?

@JR-Morgan
Copy link
Member

Potentially yes.
I think the best way for us to do this is, after installing the dependencies successfully, let's delete the requirements.txt file.
and update our dependency installation to check for the existence of the requirements.txt

This way, we only run pip once (assuming it was successful).
and this should handle updating the plugin too (I.e new versions of our connector with a bundled requirements.txt).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants