feat(UI): CNX-9070 update connectors to use new fe2 terminology #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JR-Morgan
commented
Feb 27, 2024
•
JR-Morgan
commented
- Updated naming to FE2
- Updated the "Open Stream in Web" button to go to the specific branch + commit, not just the stream (and ofcourse, working with FE1 and FE2 accounts
- Marked a couple functions as deprecated (Code that were not using, or maintaining)
* Increased default branch get to 100 limit, and added as mesh conversion for text + surfaces + metaball * poetry lock * Upgraded typing module * FE2 URL support * Raised exceptions now display to user
JR-Morgan
changed the title
JR-Morgan
changed the title
JR-Morgan
changed the title
JR-Morgan
changed the title
clairekuang
reviewed
Feb 28, 2024
| @@ -11,19 +11,19 @@ | |||
|
|
|||
| class DeleteCommit(bpy.types.Operator): | |||
| """ | |||
| Deletes the selected commit from the selected stream. | |||
| Permanently deletes the selected version from the selected model. | |||
There was a problem hiding this comment.
is the change from project (stream) to model intentional?
There was a problem hiding this comment.
It is, I was trying to align with the new api. Where versions are a property of a model, and not of a stream.
But... perhaps we could discuss this more as a team, and align on our naming here.
clairekuang
approved these changes
Feb 28, 2024
JR-Morgan
deleted the
CNX-8778-Update-Connectors-to-use-new-FE2-Terminology
branch
JR-Morgan
added a commit
that referenced
this pull request
May 14, 2024
* feat(UI): CNX-9070 update connectors to use new fe2 terminology (#186) * feat: CNX-8705 fe2 ur ls in blender (#182) * Increased default branch get to 100 limit, and added as mesh conversion for text + surfaces + metaball * poetry lock * Upgraded typing module * FE2 URL support * Raised exceptions now display to user * Fixed unused imports * Updated terminology to fe2 * merge from stash * comments * bl_descriptions * bl_desc * new urls * Updated naming of revit elements to include family type (#193)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.