Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(w3c/headers): allow localizing multiple_alternates #3953

Merged
merged 2 commits into from
Jan 11, 2022
Merged

fix(w3c/headers): allow localizing multiple_alternates #3953

merged 2 commits into from
Jan 11, 2022

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Jan 11, 2022 •
edited
Loading

Small refactor to allow localization of "multiple_alternates".

@sidvishnoi sidvishnoi changed the title l10n(w3c/templates/headers): allow localizing multiple_alternates fix(w3c/headers): allow localizing multiple_alternates Jan 11, 2022
sidvishnoi
sidvishnoi approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One optional suggestion.
(Don't forget to update commit message before merge!)

@marcoscaceres marcoscaceres merged commit 2757678 into develop Jan 11, 2022
@marcoscaceres marcoscaceres deleted the multiple_alts branch January 11, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidvishnoi sidvishnoi sidvishnoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoscaceres @sidvishnoi