Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/title): handle line break in title #3807

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Oct 5, 2021

closes #3798

Title becomes:
Screen Shot 2021-10-05 at 3 53 39 pm

@marcoscaceres marcoscaceres requested a review from xfq October 5, 2021 04:49
src/core/title.js Outdated Show resolved Hide resolved
src/core/title.js Outdated Show resolved Hide resolved
Copy link
Contributor

@xfq xfq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@xfq
Copy link
Contributor

xfq commented Oct 5, 2021

Note that this is not just for localized doc titles, some other specs (likes webauthn-2) also have titles that contain breaking lines.

@sidvishnoi sidvishnoi changed the title fix(core/titles): handle localized doc titles fix(core/title): handle line break in title Oct 5, 2021
@marcoscaceres marcoscaceres merged commit 5bd6ad6 into develop Oct 5, 2021
@marcoscaceres marcoscaceres deleted the title_handling branch October 5, 2021 11:11
@marcoscaceres
Copy link
Contributor Author

It might be a few days until we get this out. Still making Process 2021 changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The title of the generated document is inconsistent with the original title
2 participants