Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanitized_params option to allow disabling sanitization #973

Closed
wants to merge 1 commit into from

Conversation

ptamilarasan
Copy link

Fixes #835 .

Changes proposed in this pull request:

  • Ability to disable sanitization

This is useful when the keys in a JSON post body contains characters like - or $

@dtkav
Copy link
Collaborator

dtkav commented Nov 10, 2019

I'd suggest we start with #1008 , and then see if it's still a problem for folks still using openapi2.
Let me know what you think!

@ptamilarasan
Copy link
Author

I'm fine with #1008 instead, as its probably the more correct way to handle this. When I get a chance I'll test the other PR and see if it addresses our issue. You mentioned openapi2 but we were affected by this in openapi 3.

@hjacobs
Copy link
Contributor

hjacobs commented Dec 3, 2019

Is this still needed after merging #1008?

@dtkav
Copy link
Collaborator

dtkav commented Dec 12, 2019

I'm pretty sure #1008 resolves this, so I'll close it for now.
Please re-open if I missed something!

@dtkav dtkav closed this Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sanitization removes sensible characters in API definition and json request body input
3 participants