Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up errors and fix hierarchy #1649

Merged
merged 6 commits into from
Feb 22, 2023
Merged

Clean up errors and fix hierarchy #1649

merged 6 commits into from
Feb 22, 2023

Conversation

RobbeSneyders
Copy link
Member

@RobbeSneyders RobbeSneyders commented Feb 21, 2023 •
edited
Loading

Fixes #1414
Fixes #590
Fixes #945
Fixes #958
Fixes #964

And generally cleans up the exception module with a consistent interface across errors and a correct hierarchy.

@RobbeSneyders RobbeSneyders added this to the Connexion 3.0 milestone Feb 21, 2023
@coveralls
Copy link

coveralls commented Feb 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4247811174

  • 79 of 87 (90.8%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 92.371%
Changes Missing Coverage Covered Lines Changed/Added Lines %
connexion/apps/flask.py 2 3 66.67%
connexion/validators/json.py 0 1 0.0%
connexion/resolver.py 2 4 50.0%
connexion/exceptions.py 56 60 93.33%
Totals Coverage Status
Change from base Build 4247623138: 0.04%
Covered Lines: 3245
Relevant Lines: 3513
💛 - Coveralls

@RobbeSneyders
Copy link
Member Author

Added commit to fix #590

@RobbeSneyders
Copy link
Member Author

And another to fix #945

@RobbeSneyders
Copy link
Member Author

Fixes #958 as well

@RobbeSneyders
Copy link
Member Author

And #964

@RobbeSneyders RobbeSneyders merged commit 90a734d into main Feb 22, 2023
@RobbeSneyders RobbeSneyders deleted the feature/clean-errors branch February 22, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruwann Ruwann Awaiting requested review from Ruwann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Connexion 3.0
2 participants
@RobbeSneyders @coveralls