Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #1631

Merged
merged 8 commits into from
Feb 12, 2023
Merged

Refactor tests #1631

merged 8 commits into from
Feb 12, 2023

Conversation

RobbeSneyders
Copy link
Member

This PR refactors our tests to prepare the activation of our tests for our AsyncApp.

The separate commits are atomic, which can be useful for reviewing.

@coveralls
Copy link

coveralls commented Feb 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4158240817

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 90.111%
Files with Coverage Reduction New Missed Lines %
connexion/operations/swagger2.py 2 94.24%
Totals Coverage Status
Change from base Build 4117434585: -0.03%
Covered Lines: 3098
Relevant Lines: 3438
💛 - Coveralls

Ruwann
Ruwann approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@Ruwann Ruwann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Noticed one typo (that was already there)

Thanks for the hint on the atomic commits, made it very clear actually to go commit by commit

tests/api/test_secure_api.py Outdated Show resolved Hide resolved
@RobbeSneyders @Ruwann
Fix typo in tests/api/test_secure_api.py
3676349 
Co-authored-by: Ruwann <ruwanlambrichts@gmail.com>
@RobbeSneyders RobbeSneyders merged commit 642a5f2 into main Feb 12, 2023
@RobbeSneyders RobbeSneyders deleted the feature/clean-tests branch February 12, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruwann Ruwann Ruwann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobbeSneyders @coveralls @Ruwann