Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPE-2702] Ergonomics Improvements #390

Closed
ThomasRooney opened this issue Jan 8, 2024 · 0 comments · Fixed by #391
Closed

[SPE-2702] Ergonomics Improvements #390

ThomasRooney opened this issue Jan 8, 2024 · 0 comments · Fixed by #391
Assignees
Labels
terraform Created by Linear-GitHub Sync

Comments

@ThomasRooney
Copy link
Member

ThomasRooney commented Jan 8, 2024

  1. Solve https://github.com/hashicorp/terraform-plugin-framework/issues/898 via altering Required: true to instead use NotNull validators when under complex nested attributes (array,object, additionalProperties, oneOf types) that are Computed+Optional. This results in less unexpected plan changes
  2. Use ValueStringPointer where possible in the RefreshFrom data mapping methods to reduce code required to do data mapping from strict SDK calls.
  3. Fix an issue with complex additionalProperties schema types (map types) that could miss some expected plan changes.
  4. There's dead code in the %s_sdk.go data mapping methods to be cleared when under a nested attribute.

From SyncLinear.com | SPE-2702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terraform Created by Linear-GitHub Sync
Projects
None yet
1 participant