Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: remove windowBits : 0 #42

Merged
merged 1 commit into from
May 23, 2017
Merged

bug: remove windowBits : 0 #42

merged 1 commit into from
May 23, 2017

Conversation

refack
Copy link
Contributor

@refack refack commented May 22, 2017

It has always been an invalid option that got replaced with Z_DEFAULT_WINDOWBITS

Since nodejs/node@9e4660b it will throw.

Ref: Failing CITGM report

@refack
bug: remove windowBits : 0
5fcab09 
It has always been an invalid option that got replaced with `Z_DEFAULT_WINDOWBITS`
@refack
Copy link
Contributor Author

refack commented May 22, 2017

/cc @indutny

@refack refack mentioned this pull request May 23, 2017
Closed
4 tasks
@daviddias
Copy link
Member

Thank you @refack :)

@daviddias daviddias merged commit 0ea5c6d into spdy-http2:master May 23, 2017
@refack refack deleted the patch-1 branch May 23, 2017 02:17
@refack
Copy link
Contributor Author

refack commented May 23, 2017

This was the first hit of our new daily CITGM follow up procedure nodejs/CTC#126 (comment)

@refack
Copy link
Contributor Author

refack commented May 23, 2017

Compatibility restoration confirmed
Ref: https://github.com/nodejs/node/wiki/CITGM-Status

@daviddias
Copy link
Member

Woot! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refack @daviddias