Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Bug For DocumentComment in v2_3 #187

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

neilnaveen
Copy link
Contributor

Concerning issue #186

  • added DocumentComment switch case for tag in parse_creation_info.go
  • added test for DocumentComment switch case
  • added file parse_document.go for the switch case above
  • added test for parse_document.go corrosponding func in v2_3
  • fixed typo in v2_2's DocumentComment test func's name made in PR Fixed Bug For DocumentComment #185

Signed-off-by: Neil Naveen 42328488+neilnaveen@users.noreply.github.com

@kzantow
Copy link
Collaborator

kzantow commented Jan 30, 2023

@neilnaveen do you think you will be able to get to the aforementioned changes in the next few days? We would like to get this done fairly soon due to the main branch currently having the bug mentioned here. If you don't have time for it, I would be happy to help -- just let me know!

@neilnaveen
Copy link
Contributor Author

@neilnaveen do you think you will be able to get to the aforementioned changes in the next few days? We would like to get this done fairly soon due to the main branch currently having the bug mentioned here. If you don't have time for it, I would be happy to help -- just let me know!

I will try to work on it this week.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- added test for DocumentComment switch case

Signed-off-by: Neil Naveen <42328488+neilnaveen@users.noreply.github.com>
- changed switch case for documentComment in v2_2
- changed test for documentComment in v2_2
- removed parse_document and parse_document_test in v2_2
- added switch case for documentComment in v2_3
- added test for DocumentComment switch case in v2_3

Signed-off-by: Neil Naveen <42328488+neilnaveen@users.noreply.github.com>
Copy link
Collaborator

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @neilnaveen !

@kzantow kzantow merged commit 2d7b6ef into spdx:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants