GitHub issue creation #38
Conversation
…se request have been submitted.
src/app/views.py
Outdated
| url = 'https://api.github.com/repos/spdx/license-list-XML/issues' | ||
| r = post(url, data=dumps(payload), headers=headers) | ||
| print r.status_code | ||
|
|
There was a problem hiding this comment.
We should add some error handling here - if the status is not a success, open a dialog "Please note that there was a problem opening the issue for the SPDX legal team. Please email spdx-legal@lists.spdx.org with SPDX ID for the license you are submitting"
There was a problem hiding this comment.
Ok sure, I am going to be working on this.
There was a problem hiding this comment.
There was a problem hiding this comment.
I would still save the info in the DB - the legal team could follow-up and create an issue manually using the information from the DB. We could enhance this in the future to email the legal team that an error occurred, but I think the warning message is fine for now.
src/app/views.py
Outdated
| """ View for creating an GitbHub issue | ||
| when submitting a new license request | ||
| """ | ||
| myToken = '' |
There was a problem hiding this comment.
We should move the token to an external file which is not under source control for security. There are a few methods we can use to do this. My preference would be to create a separate Python file with myToken defined. We would import from this file here. Then we would add the file to the .gitignore so that the tokens do not get accidentally committed.
There was a problem hiding this comment.
That solution sounds good. I will work on it.
…ccess message when on submission success.
…se request have been submitted.
src/app/views.py
Outdated
| <<<<<<< HEAD | ||
| return r.status_code | ||
| ======= | ||
| >>>>>>> c40bd705c4a9cf86510cf680da0912e9ec650223 |
There was a problem hiding this comment.
It looks like you committed some merge conflict text
|
I'll go ahead and merge into the the license-submittal branch |
Any suggestion please let me know @goneall @rtgdk