Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new license: BSD-Systemics-W3Works #2229

Merged
merged 3 commits into from
Jan 2, 2024
Merged

new license: BSD-Systemics-W3Works #2229

merged 3 commits into from
Jan 2, 2024

Conversation

xsuchy
Copy link
Collaborator

@xsuchy xsuchy commented Oct 26, 2023

Fixes: #2169

@xsuchy
Copy link
Collaborator Author

xsuchy commented Oct 27, 2023

I believe that the failed check is not because of the content of the PR, but because failed CI script.

Fixes: spdx#2169
Signed-off-by: Miroslav Suchý <msuchy@redhat.com>
@swinslow
Copy link
Member

Thanks @xsuchy -- very strange. I agree this looks like a script issue. It's saying that BSD-Systemics is matching this one, though that seems very odd given that this clearly has additional text (as non-optional required text) so it shouldn't be matching.

I'm going to play around with it a bit more to see what's going on. I'm wondering if perhaps it's something to do with the match=".*" alt-tags matching more than they're supposed to. I'll take a closer look and will follow up.

@jlovejoy
Copy link
Member

jlovejoy commented Nov 6, 2023

was there another instance of this license found with a different name? I noticed that @xsuchy put markup around all the names, but we usually don't do that if it's a one-off license (or until we find another example). Not sure if that would mess up the tests?

@xsuchy
Copy link
Collaborator Author

xsuchy commented Nov 6, 2023

It is only one instance. I added there the alts because I got here one thumbs up. #2169 (comment)

@jlovejoy
Copy link
Member

It is only one instance. I added there the alts because I got here one thumbs up. #2169 (comment)

I think that was markup for spelling errors, not names. Just wondering if that in any way was contributing to failing tests.

@xsuchy
Copy link
Collaborator Author

xsuchy commented Nov 10, 2023

spelling errors, not names

??? what names? I thought that I added for spelling errors only. Do I miss something?

@jlovejoy
Copy link
Member

jlovejoy commented Jan 2, 2024

well, removing the alt markup around the names worked so I'm merging!

@jlovejoy jlovejoy merged commit a7220b6 into spdx:main Jan 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New license request: BSD-Systemics-W3Works
3 participants