Renamed graph.bfs_edges to edge_bfs
#1604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWeber42
force-pushed
the
rename-graph-bfs-edges
branch
from
0aca744
to
1431f36
Compare
BenWeber42
force-pushed
the
rename-graph-bfs-edges
branch
from
1431f36
to
abe5a86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
networkxhas similar methodsbfs_edgesandedge_bfsfor their graph classes. There is a slight and documented difference between the two: https://networkx.org/documentation/stable/reference/algorithms/generated/networkx.algorithms.traversal.edgebfs.edge_bfs.html#networkx.algorithms.traversal.edgebfs.edge_bfsUnfortunately, our
graph.bfs_edgesbehaves differently tonetworkx'sbfs_edges. In fact, it behaves exactly likenetworkx'sedge_bfs. To avoid future confusion (just happened to me), I propose renaming ourbfs_edgestoedge_bfsto be consistent withnetworkx.