Allow specifying errorIdentifier to RuleError
#97
Conversation
|
Oh nice, thanks! I always wanted to start using |
ruudk
force-pushed
the
identifier
branch
3 times, most recently
from
e89bf51
to
35af166
Compare
|
@spaze I have no idea how to solve the phpcs issues. They conflict with each other. If I run |
Oh what a mess! :-D Couldn't hit the problem first but then I ran I'll update the coding style to remove the new requirement. Sorry for the trouble and thanks for hitting it before I do :-) |
Ultimately every error in PHPStan should have its own unique identifier so that its possible to group by error type and ignore errors based on identifier. phpstan/phpstan#1686 (comment) phpstan/phpstan#3065
|
@ruudk all green now again :-) As an extra I've also added PHP 8.1 tests and rebased this branch. Let me know once the PR is ready, I'll re-review or something. Currently sort of busy so please allow a day or 2 (or 5). Thanks! |
spaze
changed the title
identifier to RuleErrorerrorIdentifier to RuleError
https://phpstan.org/blog/phpstan-1-11-errors-identifiers-phpstan-pro-reboot#error-identifiers Original support for optional identifiers added in #97, this adds a default one which you can still override as before. Previously, the identifier would be added, now it would override the default one.
https://phpstan.org/blog/phpstan-1-11-errors-identifiers-phpstan-pro-reboot#error-identifiers Original support for optional identifiers added in #97, this adds a default one which you can still override as before. Previously, the identifier would be added, now it would override the default one.
https://phpstan.org/blog/phpstan-1-11-errors-identifiers-phpstan-pro-reboot#error-identifiers Original support for optional identifiers added in #97, this adds a default one which you can still override as before. Previously, the identifier would be added, now it would override the default one.
Ultimately every error in PHPStan should have its own unique identifier so that its
possible to group by error type and ignore errors based on identifier.
phpstan/phpstan#1686 (comment)
phpstan/phpstan#3065