Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode ENT_QUOTES as int 3 in disallowed-loose-calls.neon config #250

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

spaze
Copy link
Owner

@spaze spaze commented Feb 13, 2024

PHPStan 1.10.58 updated nette/di from v3.1.5 to v3.1.10 and possibly that's the reason why ::constant is not accepted anymore.
phpstan/phpstan-src#2907

The config file is tested so even if the value of the constant would change, however unlikely, it would be detected by failing tests.

Close #249

Introduced in #222 as a fix for phpstan/phpstan#10223

@spaze spaze self-assigned this Feb 13, 2024
PHPStan 1.10.58 updated nette/di from v3.1.5 to v3.1.10 and possibly that's the reason why `::constant` is not accepted anymore.
phpstan/phpstan-src#2907

The config file is tested so even if the value of the constant would change, however unlikely, it would be detected by failing tests.

Close #249

Introduced in #222 as a fix for phpstan/phpstan#10223
@spaze spaze merged commit 6d49c14 into main Feb 13, 2024
74 checks passed
@spaze spaze deleted the spaze/hardcode-ent_quotes branch February 13, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disallowed-loose-calls.neon broke with PHPStan 1.10.58
1 participant