Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tel: links #53

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Conversation

mrk-j
Copy link
Contributor

@mrk-j mrk-j commented Mar 24, 2022

When merged this PR adds support for tel: links. We came across this 'issue' when using spatie/menu.

I hope you can merge this! Thank you 🦾

@freekmurze
Copy link
Member

I think it makes sense to merge this, but I think it's a breaking change. Some people might now rely on the fact that we throw an exception when we come across a non-http(s) link.

@mrk-j
Copy link
Contributor Author

mrk-j commented Mar 28, 2022

True, there is already support for mailto: links in the package. So non-http(s) links are already allowed in some form. How do you want to proceed?

@freekmurze
Copy link
Member

Ah indeed! I've check in our package that use this package, and it seems we already check everywhere on the right protocol.

I'm going to assume that our other package users to do this too and consider this a non-breaking change.

Thanks for your work on this! 👍

@freekmurze freekmurze merged commit 9053167 into spatie:main Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants