Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locale not supporting underscores #27

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Fix locale not supporting underscores #27

merged 1 commit into from
Apr 3, 2019

Conversation

Tarpsvo
Copy link
Contributor

@Tarpsvo Tarpsvo commented Apr 3, 2019

Fix #26

@freekmurze
Copy link
Member

Have you tested these changes?

@Tarpsvo
Copy link
Contributor Author

Tarpsvo commented Apr 3, 2019

Hey!

Yes I have. I tested it manually with models that had up to 6 different locales and it worked as expected.

I do not know why the field was previously decoupled from the original attributes though (resorted to parsing the modified attribute string, instead of using the original attributes), even though all the original data was available ($locale, $originalAttribute).

@freekmurze freekmurze merged commit d31b08e into spatie:master Apr 3, 2019
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants