Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update dependencies #31

Merged
merged 8 commits into from
Sep 7, 2022
Merged

Conversation

mrk-j
Copy link
Contributor

@mrk-j mrk-j commented Jun 2, 2022

Hi,

We were using this package but it wasn't working anymore since at least PHP 8.1, I took the liberty updating the dependencies.

Let me know if there are any issues and/or if you want to merge this.

Thank you 😄

@mrk-j mrk-j marked this pull request as ready for review June 2, 2022 07:13
@freekmurze
Copy link
Member

Very nice, could you also make the tests / style checks run on GitHub actions?

You can copy some stuff from our packages: https://github.com/spatie/laravel-backup/tree/main/.github/workflows

@mrk-j
Copy link
Contributor Author

mrk-j commented Jun 3, 2022

I will look into this in the coming days.

@bbashy
Copy link

bbashy commented Aug 30, 2022

Would be good to have this on php 8.1

@mrk-j mrk-j changed the title Update dependencies [WIP] Update dependencies Sep 6, 2022
@mrk-j
Copy link
Contributor Author

mrk-j commented Sep 6, 2022

I think everything must be in order now. As far as I can see at least the PHP CS Fixer has ran. I'm not entirely sure if all is OK now. Can you check?

@freekmurze
Copy link
Member

Seems ok when quickly glancing over the code.

Did you test out the CLI tool itself? Is it working?

@mrk-j
Copy link
Contributor Author

mrk-j commented Sep 7, 2022

It is:

➜  mixed-content-scanner-cli git:(update-dependencies) ✗ ./mixed-content-scanner scan https://spatie.be


Start scanning https://spatie.be for mixed content
==================================================

https://spatie.be/: ok
https://spatie.be/vacancies: ok
https://spatie.be/products: ok
https://spatie.be/web-development: ok
https://spatie.be/about-us: ok
https://spatie.be/guidelines: ok
https://spatie.be/blog: ok
https://spatie.be/docs: ok
https://spatie.be/login: ok
[...]

➜  mixed-content-scanner-cli git:(update-dependencies) ✗ ./mixed-content-scanner scan https://www.mixedcontentexamples.com/Test/NonSecureImage


Start scanning https://www.mixedcontentexamples.com/Test/NonSecureImage for mixed content
=========================================================================================

https://www.mixedcontentexamples.com/Test/NonSecureImage: found mixed content on element img with url http://www.mixedcontentexamples.com/Content/Test/steveholt.jpg

Scan results
============

Found 1 pieces of mixed content
 * https://www.mixedcontentexamples.com/Test/NonSecureImage: found mixed content on element img with url http://www.mixedcontentexamples.com/Content/Test/steveholt.jpg

Found 0 pages without mixed content

@freekmurze freekmurze merged commit f86952a into spatie:main Sep 7, 2022
@freekmurze
Copy link
Member

Thank you for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants