Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file option #63

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Add file option #63

merged 2 commits into from
Oct 1, 2020

Conversation

squatto
Copy link
Contributor

@squatto squatto commented Oct 1, 2020

I've had a number of instances where I needed to tail a specific log file (for example, I log third-party API calls to a different file for each service). This PR adds a --file option that lets you specify the file that you want to tail, rather than only being able to see the last-modified file in the directory.

The relevant test was added, and I updated the readme to describe the use case and usage. I also added a config value to allow the file to specified per-environment (optional, of course).

Please let me know any feedback or requested changes. Thank you!

- Add `file` option to the command
- Add `file` key to config
- Add supporting test
- Add instructions to README.md
- Clean up a couple of unrelated lines in the command
  (lines 17 and 74 in the updated file)
@freekmurze
Copy link
Member

This is a high quality PR, thank you!

@freekmurze freekmurze merged commit 387bbb1 into spatie:master Oct 1, 2020
@squatto squatto deleted the add-file-option branch October 1, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants