Add context to ApplicationLogPayload #293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log context is not being passed to the
ApplicationLogPayload
class currently (relates to #162) and this PR simply passes that data.Unfortunately it does not mean that the context is shown in Ray, because apparently the formatting of the context is not currently implemented in the Ray app.
Where is the formatting logic for the
Payload
subclasses? 🤔 is that somewhere in https://github.com/spatie/ray or the Electron app itself?I propose that we show the message like we currently do, but that we add the context using the same formatter used for the
Spatie\Ray\Payloads\CarbonPayload
class or the\Spatie\Ray\Payloads\TablePayload