Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Slow query configuration #269

Merged
merged 7 commits into from
Jul 29, 2022

Conversation

fullstackfool
Copy link
Contributor

The slow query logging uses 500ms when manually activating via ray()->slowQueries();. When activated via the ray.php config SEND_SLOW_QUERIES_TO_RAY value, however, it defaults to 0ms causing all queries to be logged.

This adds a configurable RAY_SLOW_QUERY_THRESHOLD=500 to the ray.php stub.

Additionally, the composer.json offered format script, but cs-fixer was not included in the dev dependencies.

@fullstackfool
Copy link
Contributor Author

Regarding tests, there are currently no tests that confirm the propagation of ray.php stub values, so unsure as to the requirement here.

@fullstackfool
Copy link
Contributor Author

fullstackfool commented Jul 28, 2022

Accompanying docs update: spatie/ray#718

@freekmurze freekmurze merged commit 1afe8d3 into spatie:main Jul 29, 2022
@freekmurze
Copy link
Member

Thanks!

@fullstackfool fullstackfool deleted the feat/slow-query-configuration branch July 29, 2022 10:04
@fullstackfool
Copy link
Contributor Author

Thank you for the adjustments & merge @freekmurze 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants