Make service provider deferrable #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Gonna merge some final PRs for the last < L5.8 version first, then merge #370 and then we're good to merge this one. Soon™️ |
You can still support older version if you want to. https://crynobone.com/articles/deferred-service-provider-compatibility/ |
|
@crynobone thanks! We'll do this until we deprecate support for L5.7 and below. @klimov-paul thanks again for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service provider has been made deferrable, removing its unnecessary loading unless registered service is requested.
Currently
QueryBuilderServiceProviderjust consumes computing resources per each HTTP request processing without any reason asQueryBuilderRequestinstance usually instantiated without DI involvement anyway.Usage of
Illuminate\Contracts\Support\DeferrableProviderrequires minimal Laravel version raise up to 5.8.