Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v7] Update Role contract to match implementation and fix PhpStan errors #2676

Closed
wants to merge 2 commits into from
Closed

[v7] Update Role contract to match implementation and fix PhpStan errors #2676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
269c32c
Update Role contract to match implementation
SanderMuller Jun 2, 2024
c750e05
Merge branch 'main' into patch-1
drbyte Jun 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Contracts/Role.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,25 +26,25 @@ public function permissions(): BelongsToMany;
*
* @throws \Spatie\Permission\Exceptions\RoleDoesNotExist
*/
public static function findByName(string $name, ?string $guardName): self;
public static function findByName(string $name, ?string $guardName = null): self;

/**
* Find a role by its id and guard name.
*
*
* @throws \Spatie\Permission\Exceptions\RoleDoesNotExist
*/
public static function findById(int|string $id, ?string $guardName): self;
public static function findById(int|string $id, ?string $guardName = null): self;

/**
* Find or create a role by its name and guard name.
*/
public static function findOrCreate(string $name, ?string $guardName): self;
public static function findOrCreate(string $name, ?string $guardName = null): self;

/**
* Determine if the user may perform the given permission.
*
* @param string|int|\Spatie\Permission\Contracts\Permission|\BackedEnum $permission
*/
public function hasPermissionTo($permission, ?string $guardName): bool;
public function hasPermissionTo($permission, ?string $guardName = null): bool;
}